DNN Platform\Website\admin\Skins\Privacy.ascx.cs & Terms.ascx.cs #5047
Labels
Milestone
Comments
|
Yes, this would be a welcome change. We would want the skin object to still default to |
|
Thank you for the feedback! I will work on this issue (and the other 3 ones) on the side line so it may take a while. Best regards & happy DNNing |
Andy9999
added a commit
to Andy9999/Dnn.Platform
that referenced
this issue
Mar 20, 2022
Fix for issue dnnsoftware#5047. This will allow to optionally remove the rel attribute from privacy and terms links. Default is still "rel=nofollow" but it could now either be changed or removed entirely from the ascx file. Unfortunately the asp.net control doesn't have a rel attribute, so we have to add it ourselves. Added Rel attribute to Privacy and Terms class and added rel="nofollow" to privacy.ascx and terms.ascx skin file.
This was
linked to
pull requests
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
By default the links to privacy and terms pages are getting a rel="nofollow" added from the CS code. There are mixed opinions on having it set to nofollow (pro and contra). Some say having it set to nofollow could look kind of shady to Google.
To change this, one currently has to recompile DNN and use a custom build.
To improve this I would suggest to remove it from the CS code and put the rel="nofollow" into the ascx files instead, where one could customize the behavior without recompiling.
I could submit this change and would be glad not having to make custom builds anymore.
Best regards & happy DNNing
Andy9999
The text was updated successfully, but these errors were encountered: