Always replace task details fragments instead of updating them. #624 #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Potential fix for the mysterious bugs on certain emulators. Fix task list item selection highlight issue by changing the twopane flag from being a TaskListFragment extra to just being read from the bool resource. Fix issue on small tablet, rotating to portrait not opening up task again. Fix issue when deleting a task and rotating. Fix the case when selected item is deleted by swiping it out in two pane mode. Fix the case when previously select task was shown incorrectly. Fix crash related to color when a new task is created with the editor. Compare task uri in ViewTaskFragment.Callback#onTaskDeleted() as well just to be sure. Rename callback methods, move implementations next to each other. Speculative fix for the crash when a task was deleted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix rotation issue after creating a task on a handset device.