Task details Fragments - always use new instance instead of updating existing one #624
Assignees
Labels
Comments
lemonboston
pushed a commit
that referenced
this issue
Jan 10, 2018
… them when new task is selected. #624
lemonboston
pushed a commit
that referenced
this issue
Jan 10, 2018
… them when new task is selected. #624
lemonboston
pushed a commit
that referenced
this issue
Jan 11, 2018
… them when new task is selected. #624
lemonboston
pushed a commit
that referenced
this issue
Jan 11, 2018
… them when new task is selected. #624
lemonboston
pushed a commit
that referenced
this issue
Jan 11, 2018
… them when new task is selected. #624
lemonboston
pushed a commit
that referenced
this issue
Jan 16, 2018
… them when new task is selected. #624
dmfs
pushed a commit
that referenced
this issue
Sep 25, 2018
… them when new task is selected. #624 Potential fix for the mysterious bugs on certain emulators. Fix task list item selection highlight issue by changing the twopane flag from being a TaskListFragment extra to just being read from the bool resource. Fix issue on small tablet, rotating to portrait not opening up task again. Fix issue when deleting a task and rotating. Fix the case when selected item is deleted by swiping it out in two pane mode. Fix the case when previously select task was shown incorrectly. Fix crash related to color when a new task is created with the editor. Compare task uri in ViewTaskFragment.Callback#onTaskDeleted() as well just to be sure. Rename callback methods, move implementations next to each other. Speculative fix for the crash when a task was deleted.
dmfs
pushed a commit
that referenced
this issue
Sep 26, 2018
Potential fix for the mysterious bugs on certain emulators. Fix task list item selection highlight issue by changing the twopane flag from being a TaskListFragment extra to just being read from the bool resource. Fix issue on small tablet, rotating to portrait not opening up task again. Fix issue when deleting a task and rotating. Fix the case when selected item is deleted by swiping it out in two pane mode. Fix the case when previously select task was shown incorrectly. Fix crash related to color when a new task is created with the editor. Compare task uri in ViewTaskFragment.Callback#onTaskDeleted() as well just to be sure. Rename callback methods, move implementations next to each other. Speculative fix for the crash when a task was deleted.
dmfs
added a commit
that referenced
this issue
Sep 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When displaying the details of a newly selected task on tablet two-pane mode, currently
ViewTaskFragment.loadUri()method is called updating an existing instance of the Fragment. This is problematic, in part because of the lifecycles. It has led to at least one bug already, and it also makes the code more complex. Replace that with a solution that always replaces the Fragment with a new one each time a different task is selected.The text was updated successfully, but these errors were encountered: