Add instance status column. Implements #572 #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds an instance status column which indicates which instance of a task is the next one to complete. This allows to filter out the instances which come after the next one.
lemonboston
reviewed
Dec 28, 2017
| @@ -237,7 +237,8 @@ | |||
| + TaskContract.Instances.INSTANCE_START_SORTING + " INTEGER, " | |||
| + TaskContract.Instances.INSTANCE_DUE_SORTING + " INTEGER, " | |||
| + TaskContract.Instances.INSTANCE_DURATION + " INTEGER, " | |||
| + TaskContract.Instances.INSTANCE_ORIGINAL_TIME + " INTEGER DEFAULT 0);"; | |||
| + TaskContract.Instances.INSTANCE_ORIGINAL_TIME + " INTEGER DEFAULT 0," | |||
There was a problem hiding this comment.
Is a space needed here after DEFAULT 0,?
There was a problem hiding this comment.
no, technically it's not required
|
|
||
|
|
||
| /** | ||
| * Create task with start and due, check datetime values including generated duration. |
There was a problem hiding this comment.
Javadoc stayed copy-pasted here.
|
|
||
|
|
||
| /** | ||
| * A {@link Single} of date and time {@link ContentValues} of an instance. |
There was a problem hiding this comment.
Not updated, copy-pasted javadoc here.
|
@lemonboston please re-review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds an instance status column which indicates which instance of a task is the next one to complete. This allows to filter out the instances which come after the next one.