Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instance distance from current #606

Closed
dmfs opened this issue Dec 30, 2017 · 3 comments
Closed

Instance distance from current #606

dmfs opened this issue Dec 30, 2017 · 3 comments

Comments

@dmfs
Copy link
Owner

dmfs commented Dec 30, 2017

In #600 we've added an instance status column which allows to distinguish between closed, current and future instances. However, it just occurred to me that we can extend the semantics of this a bit and use the field as a kind of instance number (or distance) with 0 being the "current instance", 1 the next one, 2 the one after the next one, etc. So instance numbers >0 would still denote upcoming instances but with the additional meaning of the distance from the current one. This could be useful in the UI. Since this is much less useful but much harder for closed instances, I propose to keep a "distance" of -1 for all closed instances.

@dmfs
Copy link
Owner Author

dmfs commented Dec 30, 2017

Since the instance_status column would be superseded by instance_distance, we should override the changes in d0ff43e, so the instance_status column doesn't make it into the next release.

dmfs added a commit that referenced this issue Dec 30, 2017
This commit replaces the `instance_status` column with a more veratile `distance_from_current` which has additional semantics for upcoming instances.
@dmfs dmfs changed the title Instance number Instance distance from current Dec 30, 2017
@lemonboston
Copy link
Contributor

I see that this instance number can increases the utility of this field.

What is not clear for me is what is the distinction between the current one 0 and next one 1 for recurrent tasks?
So let's say I have a weekly recurrent task on Wednesday and it's Monday now, what number would the task on Wednesday have?

@dmfs
Copy link
Owner Author

dmfs commented Jan 2, 2018

If there is no other instance between now and Wednesday, the one on this Wednesday would be 0 and each instance thereafter would have it's number increased by 1 (compared to its predecessor).

dmfs added a commit that referenced this issue Jan 2, 2018
…#607)

This commit replaces the `instance_status` column with a more veratile `distance_from_current` which has additional semantics for upcoming instances.
@dmfs dmfs closed this as completed Jan 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants