Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update portuguese translation #427

Closed
wants to merge 2 commits into from
Closed

Update portuguese translation #427

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Sep 18, 2017

No description provided.

@dmfs dmfs requested a review from lemonboston September 19, 2017 10:32
@dmfs
Copy link
Owner

dmfs commented Sep 19, 2017

@lemonboston please help to review

@lemonboston
Copy link
Contributor

Something is strange here, the values-pt-rPT/strings.xml file I see in our master is different from the one this change is originating from. There is also conflict in the file according to github here. @YSmhXQDd6Z Could you please rebase on this repository's master?

Or if that's problematic, you can also provide the strings.xml file as an attachment of a new issue here, we can commit it.

@lemonboston
Copy link
Contributor

Github says here that there are unresolved conflicts in the file, @YSmhXQDd6Z could you please resolve them?

@dmfs
Copy link
Owner

dmfs commented Sep 20, 2017

@lemonboston please copy the file from @YSmhXQDd6Z's branch, fix the conflicts and submit a new PR.

@dmfs
Copy link
Owner

dmfs commented Oct 6, 2017

this will be handled by #429

@dmfs dmfs closed this Oct 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants