Settings screen with Notifications checkbox. #279 #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
b76b7cc to
5c1a4d7
Compare
dmfs
approved these changes
Sep 4, 2017
lemonboston
pushed a commit
that referenced
this pull request
Sep 18, 2017
dmfs
pushed a commit
that referenced
this pull request
Sep 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The base branch is a new
settings/masterfor this pull request, since I've only added the existing Notifications switch to the new Settings screen here, and I suppose we wouldn't release it with at least 2 items there.One question here is the order of items in the menu. I see the items are added from both
TaskListActivityandTaskListFragment. Since they are always shown together could we maybe use just one of them?