Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings #279

Closed
dmfs opened this issue Oct 3, 2016 · 3 comments
Closed

Settings #279

dmfs opened this issue Oct 3, 2016 · 3 comments
Assignees
@lemonboston
Labels
enhancement

Comments

@dmfs
Copy link
Owner

dmfs commented Oct 3, 2016

Many of the current feature requests require a proper settings screen.
@lemonboston
Copy link
Contributor

An earlier note about this story from @dmfs:

Regular PreferenceFragment, on Android 2.x it's not supported, just disable it.
Add to settings:

  • show notification or not
  • notification sound (maybe allow to set independently for start and due)
  • vibrate on notification or not

lemonboston pushed a commit that referenced this issue Jul 19, 2017
Settings screen with Notifications checkbox. #279
f8bba8b
lemonboston pushed a commit that referenced this issue Jul 19, 2017
Settings screen with Notifications checkbox. #279
b76b7cc
@lemonboston
Copy link
Contributor

@dmfs I've submitted a PR #389 with a Settings screen containing only "show notification or not".
Is continuing with this a priority now and if so what should be the next settings to add?

@dmfs
Copy link
Owner Author

dmfs commented Jul 20, 2017

We've received a couple of requests to change the notification sound (#124) and disable notification vibration (#305).
These should be next.

lemonboston pushed a commit that referenced this issue Aug 9, 2017
Settings screen with Notifications checkbox. #279
5c1a4d7
dmfs pushed a commit that referenced this issue Sep 4, 2017
@dmfs
Settings screen with Notifications checkbox. #279 (#389)
eb35d88
@dmfs dmfs closed this as completed Sep 8, 2017
@lemonboston lemonboston mentioned this issue Sep 15, 2017
Merged
lemonboston pushed a commit that referenced this issue Sep 18, 2017
Settings screen with Notifications checkbox. #279 (#389)
c2ddb53
dmfs pushed a commit that referenced this issue Sep 19, 2017
@dmfs
Settings screen with Notifications checkbox. #279 (#389)
bb00d06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lemonboston lemonboston

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lemonboston @dmfs