-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node: Replace usage of Variant with SumType #291
Conversation
Codecov Report
@@ Coverage Diff @@
## master #291 +/- ##
==========================================
- Coverage 96.03% 95.43% -0.60%
==========================================
Files 28 28
Lines 4086 4100 +14
==========================================
- Hits 3924 3913 -11
- Misses 162 187 +25
Continue to review full report at Codecov.
|
4e06a9a
to
cf1e82d
Compare
Green |
It's a requirement to be able to support DIP1000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good. Just a few things to address.
@Herringway : Updated |
Except it doesn't work for LDC, and those error messages are really unhelpful. |
it's pretty noisy, but I can see that LDC is deciding that the |
@Herringway : The bug is related to |
Fixes #281