Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of std.sumtype.SumType instead of std.variant.Algebraic #281

Closed
tom-tan opened this issue Jan 20, 2022 · 1 comment · Fixed by #291
Closed

Use of std.sumtype.SumType instead of std.variant.Algebraic #281

tom-tan opened this issue Jan 20, 2022 · 1 comment · Fixed by #291

Comments

@tom-tan
Copy link
Contributor

tom-tan commented Jan 20, 2022

Currently Node type internally uses std.variant.Algebraic but the official document says it becomes outdated.

Is there a plan to migrate from Algebraic to std.sumtype.SumType or can I send a pull request for it?
IMO it is worth doing because it enables D-YAML to work with attributes such as pure.

@Herringway
Copy link
Member

It is something I wanna do eventually, but at the moment it doesn't really add a lot of value by itself. There are a few other dependencies that block pure, like std.regex, and that doesn't appear to be changing anytime soon...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants