Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shader binding bug #356

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Fix shader binding bug #356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/render/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1154,7 +1154,7 @@ impl SpecializedRenderPipeline for ParticlesRenderPipeline {
.create_bind_group_layout("hanabi:buffer_layout_render", &entries);

let mut layout = vec![self.view_layout.clone(), particles_buffer_layout];
let mut shader_defs = vec![];
let mut shader_defs = vec!["SPAWNER_READONLY".into()];

// Key: PARTICLE_TEXTURE
if key.has_image {
Expand Down
5 changes: 5 additions & 0 deletions src/render/vfx_common.wgsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,12 @@ struct Spawner {
inverse_transform: mat3x4<f32>, // transposed (row-major)
spawn: i32,
seed: u32,
// Can't use storage<read> with atomics
#ifdef SPAWNER_READONLY
count: i32,
#else
count: atomic<i32>,
#endif
effect_index: u32,
#ifdef SPAWNER_PADDING
{{SPAWNER_PADDING}}
Expand Down
Loading