Fix shader binding bug #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a bug where the render shader attempts to bind the `Spawner` storage buffer as read-only, but that struct is defined as containing an atomic variable, which according to the WGSL specification requires write access. Add a pipeline define `SPAWNER_READONLY` to redefine that struct field as non-atomic, to allow read-only binding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug where the render shader attempts to bind the
Spawnerstorage buffer as read-only, but that struct is defined as containing an atomic variable, which according to the WGSL specification requires write access. Add a pipeline defineSPAWNER_READONLYto redefine that struct field as non-atomic, to allow read-only binding.