-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the Moroccan localflavor #270
Conversation
Nice job!! |
Thanks for you contribution. We're in the process of deprecating the phone number fields in localflavor. We now recommend that people use https://github.com/stefanfoulis/django-phonenumber-field. Could you remove the phone number field after which I'll do a full review. Thanks! |
Generally, geographic names are marked for translation. I can suppose for example that one may want to translate the names to Arabic. It's not a requirement, just a suggestion. |
Thanks @claudep . This is my mistake, I'll correct it. |
Changes
Added PhoneNumber field.All Changes
Add an entry to the docs/changelog.rst describing the change.
Add an entry for your name in the docs/authors.rst file if it's not
already there.
Adjust your imports to a standard form by running this command:
New Fields Only
Prefix the country code to all fields.
Field names should be easily understood by developers from the target
localflavor country. This means that English translations are usually
not the best name unless it's for something standard like postal code,
tax / VAT ID etc.
Prefer 'PostalCodeField' for postal codes as it's
international English; ZipCode is a term specific to the United
States postal system.
Add meaningful tests. 100% test coverage is not required but all
validation edge cases should be covered.
Add
.. versionadded:: <next-version>
comment markers to newlocalflavors.
Add documentation for all fields.