Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add premium guilds #960

Merged
merged 5 commits into from
May 30, 2019
Merged

Add premium guilds #960

merged 5 commits into from
May 30, 2019

Conversation

AL1L
Copy link
Contributor

@AL1L AL1L commented May 24, 2019

No description provided.

@ghost
Copy link

ghost commented May 24, 2019

What do those tiers mean?

@UndarkAido
Copy link
Contributor

If you're trying to make a suggestion, that should be done on https://feedback.discordapp.com

@z64
Copy link
Contributor

z64 commented May 24, 2019

@Aidoboy This PR references an in-development feature that hasn't been fully released by Discord yet.

@UndarkAido
Copy link
Contributor

@z64 Ah, ok. Seemed kind of random. Thought it might have been something like that, but his account didn't seem to be associated with Discord besides the avatar.

@z64
Copy link
Contributor

z64 commented May 24, 2019

He's not; but sometimes people poke around the client or API and find new features and offer to document them anyways. Non-staff users, in general, contribute a lot to the API documentation 🙂

@Zoddo
Copy link
Contributor

Zoddo commented May 24, 2019

Premium refers to Server Boosts: https://support.discordapp.com/hc/en-us/articles/360028038352

@queer queer mentioned this pull request May 24, 2019
Closed
@xJade00 xJade00 mentioned this pull request May 25, 2019
Closed
msciotti
msciotti reviewed May 28, 2019
View reviewed changes
docs/resources/Guild.md Outdated Show resolved Hide resolved
msciotti
msciotti reviewed May 28, 2019
View reviewed changes
docs/resources/Guild.md Outdated Show resolved Hide resolved
@msciotti
Copy link
Contributor

Also, here's your friendly caveat of "This is an experiment and all things around it are subject to change" 😄

AL1L added 2 commits May 29, 2019 18:39
@AL1L
Resolving @msciotti's reviews
008fe0d
@AL1L
@Geo1088's suggestion
2964da3 
Should have read it all before my last commit
@msciotti
Copy link
Contributor

Looks good to me! Thanks!

@msciotti msciotti merged commit 3d8cca0 into discord:master May 30, 2019
@AL1L AL1L deleted the patch-1 branch May 30, 2019 01:51
@Seklfreak Seklfreak mentioned this pull request Jun 8, 2019
Merged
@AL1L
Copy link
Contributor Author

AL1L commented Jun 10, 2019 •
edited
Loading

Now that it's on the live site, I realize that the link to premium tier is not working and I should have added the two fields to the example guild object. Someone should create an issue or I might make another PR

@Zoddo
Copy link
Contributor

Zoddo commented Jun 10, 2019

The link has been fixed in #975, but it's not deployed yet.

DevYukine added a commit to spec-tacles/Spectacles.NET that referenced this pull request Jul 26, 2019
@DevYukine
[Feature] Update to latest API Changes
f53c3f1 
This includes

- Server Boosting discord/discord-api-docs#960

- remove of _trace on Identify payload discord/discord-api-docs#967

- opt out for presence & typing events discord/discord-api-docs#1016
@advaith1 advaith1 mentioned this pull request Sep 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@z64 z64 z64 left review comments

@msciotti msciotti msciotti left review comments

@eritbh eritbh eritbh left review comments

@DV8FromTheWorld DV8FromTheWorld DV8FromTheWorld left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@AL1L @UndarkAido @z64 @Zoddo @msciotti @DV8FromTheWorld @eritbh