Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guild object premium_subscription_count & max_video_channel_users never undefined? #2034

Closed
crowlKats opened this issue Sep 2, 2020 · 2 comments
Labels

Comments

@crowlKats
Copy link
Contributor

When are the premium_subscription_count & max_video_channel_users properties on the guild object undefined? I cant seem to find such case.

@advaith1
Copy link
Contributor

advaith1 commented Sep 2, 2020

(said this in discord but commenting here so others can see)

max_video_channel_users was documented in #1512, and looks like it was marked as undefined because that was before the feature rolled out to all guilds, so it was undefined for some. idk if it can still be undefined

premium_subscription_count was documented in #960, maybe it is undefined in some cases or it was a mistake

(we should wait for staff to confirm)

@night night added the invalid label Sep 29, 2020
@night
Copy link
Member

night commented Sep 29, 2020

it doesn't hurt anything for it to be marked as undefined, and offers us flexibility if we need to remove the field in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants