-
-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional PinSlotJoint
2D implementation with DOF: 1 translation + 1 rotation
#775
base: master
Are you sure you want to change the base?
Conversation
fe7284f
to
1c62ac1
Compare
Just rebased this PR on dimforge:master to fix the CI |
Thanks for the PR! I'm a bit skeptical on the naming, I think this behaviour refers more accurately a
Those are not blocking actions to be taken in the PR (1 is uncertain, 2 is trivial and can be done at merge-time), but hopefully helps understanding the current state of approval consideration. I'm still approving this PR as I believe this brings value. |
Thanks for the feedback, it might be good to rename the joint from I will start working on the documentation today and reference the inspirations for this joint there. |
PinSlotJoint
2D implementation with DOF: 1 translation + 1 rotation
Implements additional
GrooveJoint
from to issue: #772The joint is currently only implemented for 2d behind the feature flag "dim2".
This PR includes a test for the
GrooveJoint
.If there is anything that i have overlooked, let me know :) I am also planning to update the documentation with this joint type if everything else looks fine.