Pm Dummy PR #2942

pm-dimagi · 2025-01-16T21:20:28Z

Summary

Dummy PR for commcare core apk build up

Feature Flag

Product Description

PR Checklist

If I think the PR is high risk, "High Risk" label is set
I have confidence that this PR will not introduce a regression for the reasons below
Do we need to enhance manual QA test coverage ? If yes, "QA Note" label is set correctly
Does the PR introduce any major changes worth communicating ? If yes, "Release Note" label is set and a "Release Note" is specified in PR description.

Automated test coverage

Safety story

cross-request: dimagi/commcare-core#1455

… into pm_connect_ui Removed a couple obsolete strings from Portuguese translations.

Pm connect UI

Refactor connect id screen UI

Pm connect bug fixes

… into jp/refactor-new-revamp-ui Added some translatable strings.

Refactor ConnectId Flow Screen UI

Refactor code

Refactor new UI and Solved Phone number picker issue

…ut assessment still pending. Removed an obsolete French string. Fixed nav crash in phone available dialog.

…d improved some layout spacing.

…rogress.

Better PIN validity checking. Better secondary phone validity checking. Improved spacing on phone verification page.

Set User Deacticate flow in new Revamp

User deactivate flow in new Ravamp

Translation added

Resolved comments

…vamp CCCT-483 || User Deactivate Flow (New Revamp)

Removed obsolete code that supported going to learn/delivery progress after download.

Always launching learn/deliver app immediately after downloading

Updated Connect page titles

Working on new delivery list screen with filter

Delivery list screen UI

Refactor

PM-bug fixes in ui

…droid into dv/connect_initial

Pm round button

…being applied in fragments).

pm-dimagi · 2025-01-16T21:21:10Z

cross-request: dimagi/commcare-core#1455

coderabbitai · 2025-01-16T21:22:05Z

📝 Walkthrough

Walkthrough

The pull request involves the removal of a public constant KEY_ENTERED_PW_OR_PIN from the LoginActivity class in the CommCare application. This constant, which was previously used to define a key for storing entered password or PIN information in SharedPreferences, has been deleted. The removal of this constant suggests a potential refactoring of the login process or a change in how password/PIN information is managed within the login activity. Without additional context, the exact implications of this change are not immediately clear, but it may indicate a modification to the authentication or credential storage mechanism in the application.

Sequence Diagram

Since the change is minimal and only involves removing a constant, a sequence diagram is not particularly meaningful in this context. The change appears to be a simple code cleanup or preparatory step for further modifications to the login process.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0a85740 and 817e5ec.

📒 Files selected for processing (1)

app/src/org/commcare/activities/LoginActivity.java (0 hunks)

💤 Files with no reviewable changes (1)

app/src/org/commcare/activities/LoginActivity.java

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: Lint Code Base

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

pm-dimagi · 2025-01-16T21:46:15Z

@damagatchi retest this please

ctsims · 2025-01-17T00:23:12Z

@damagatchi retest this please

…into pm_core_pr

pm-dimagi · 2025-01-17T12:06:56Z

@damagatchi retest this please

pm-dimagi · 2025-01-17T12:42:24Z

@damagatchi retest this please

pm-dimagi · 2025-01-17T13:00:46Z

@damagatchi retest this please

OrangeAndGreen

Requested a couple renames for consistency so future devs don't get confused

OrangeAndGreen · 2025-01-17T19:58:40Z

app/src/org/commcare/activities/EntitySelectActivity.java

@@ -705,8 +705,8 @@ public boolean onCreateOptionsMenu(Menu menu) {
        menu.add(0, MENU_SORT, MENU_SORT, Localization.get("select.menu.sort")).setIcon(
                android.R.drawable.ic_menu_sort_alphabetically);
        if (isMappingEnabled) {
-            menu.add(0, MENU_MAP, MENU_MAP, Localization.get("select.menu.map")).setIcon(
-                    android.R.drawable.ic_menu_mapmode);
+            menu.add(0, MENU_MAP, MENU_MAP, Localization.get("select.menu.scan")).setIcon(


Seems dangerous to leave this as MENU_MAP if the action is now to scan instead.

OrangeAndGreen · 2025-01-17T19:58:42Z

app/src/org/commcare/activities/EntitySelectActivity.java

@@ -743,6 +743,9 @@ public boolean onPrepareOptionsMenu(Menu menu) {
        menu.findItem(MENU_SORT).setEnabled(adapter != null);
        // hide sorting menu when using async loading strategy
        menu.findItem(MENU_SORT).setVisible((shortSelect == null || shortSelect.hasSortField()));
+        if(isMappingEnabled) {
+            menu.findItem(R.id.barcode_scan_action_bar).setIcon(R.drawable.ic_marker);


Likewise, think we should rename barcode_scan_action_bar to reflect the change to a map button

The merge-base changed after approval.

OrangeAndGreen and others added 30 commits September 19, 2024 15:43

Merge branch 'connect_qa' of https://github.com/dimagi/commcare-android…

3ef6e12

… into pm_connect_ui Removed a couple obsolete strings from Portuguese translations.

Merge pull request #2861 from dimagi/pm_connect_ui

29424cf

Pm connect UI

Refactor connect id screen UI

d391818

Refactor connect id screen UI

-bug fixes

86031f3

-bug fixes

afbaf30

Small cleanup. Removed magic number.

5143df7

Merge pull request #2863 from dimagi/pm_connect_bug

c2be990

Pm connect bug fixes

Merge branch 'connect_qa' of https://github.com/dimagi/commcare-android…

4fc8813

… into jp/refactor-new-revamp-ui Added some translatable strings.

Merge pull request #2862 from dimagi/jp/refactor-new-revamp-ui

52c74b0

Refactor ConnectId Flow Screen UI

Refactor code

c4e407b

Refactor code

Merge branch 'connect_qa' into jp/refactor-new-revamp-ui-2

10fddb1

Merge pull request #2864 from dimagi/jp/refactor-new-revamp-ui-2

6d19f7d

Refactor new UI and Solved Phone number picker issue

Updating progress ring in learning progress when learning completed b…

8a00380

…ut assessment still pending. Removed an obsolete French string. Fixed nav crash in phone available dialog.

Removed "not seeing expected progress" label in learning progress, an…

6e0b486

…d improved some layout spacing.

A little more spacing cleanup for consistency in learn and delivery p…

f054e3a

…rogress.

Restored ability to resume registration after being interrupted.

4211679

Better PIN validity checking. Better secondary phone validity checking. Improved spacing on phone verification page.

Set User Deacticate flow in new Revamp

e8b0d85

Set User Deacticate flow in new Revamp

User deactivate flow in new Ravamp

aa56ec2

User deactivate flow in new Ravamp

Translation added

35e252f

Translation added

Resolved comments

925183b

Resolved comments

Merge pull request #2866 from dimagi/jp/user-deactivation-flow-new-re…

84a508f

…vamp CCCT-483 || User Deactivate Flow (New Revamp)

Always launching learn/deliver app immediately after downloading.

3d74fac

Removed obsolete code that supported going to learn/delivery progress after download.

Configuring several Connect page titles to match designs in Figma.

91d68da

Merge pull request #2868 from dimagi/dv/ccct-492-app-launch

54b21b5

Always launching learn/deliver app immediately after downloading

Merge pull request #2869 from dimagi/dv/ccct-489-page-titles

e59f90e

Updated Connect page titles

-bug fixes in ui

a5d743e

Delivery progress revisit

8c22c3d

Working on new delivery list screen with filter

Delivery list screen UI

4b608c0

Delivery list screen UI

Refactor

76c1f22

Refactor

Merge pull request #2872 from dimagi/pm_ui_changes

c974298

PM-bug fixes in ui

shubham1g5 and others added 11 commits January 15, 2025 11:50

fix location permission check

d34cf10

Puts custom map marker behind a custom app setting

a390db2

Merge branch 'commcare_2.55' of https://github.com/dimagi/commcare-an…

3ad56b2

…droid into dv/connect_initial

-rounded button issue resolved

c0896f3

-bug fixing for text

c55ef7f

Added logging for intermittent crash storing job in DB

4a39db2

Merge branch 'dv/connect_initial' into pm_round_button

1b2fd2b

Merge pull request #2941 from dimagi/pm_round_button

2e51788

Pm round button

Forcing style for MaterialButtons in ConnectID screens (style wasn't …

ffdb291

…being applied in fragments).

Changed version to 2.56 (for beta)

31317ea

-dummy commit

817e5ec

pm-dimagi added the cross requested label Jan 16, 2025

Merge branch 'mapIcon' of https://github.com/dimagi/commcare-android …

9359653

…into pm_core_pr

-added path odf xpath in FormStorageTest

d2a218e

OrangeAndGreen and others added 2 commits January 17, 2025 08:38

Added build number to analytics entries

a0e88db

-replace barcode with view on map

4f55119

OrangeAndGreen requested changes Jan 17, 2025

View reviewed changes

-replace the name

83934e4

pm-dimagi requested a review from OrangeAndGreen January 17, 2025 20:17

-replace the name

c322bb1

OrangeAndGreen previously approved these changes Jan 17, 2025

View reviewed changes

Merge branch 'dv/connect_initial' into pm_core_pr

a423387

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pm Dummy PR #2942

Pm Dummy PR #2942

pm-dimagi commented Jan 16, 2025 •

edited

Loading

pm-dimagi commented Jan 16, 2025

coderabbitai bot commented Jan 16, 2025

Walkthrough

Sequence Diagram

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

pm-dimagi commented Jan 16, 2025

ctsims commented Jan 17, 2025

pm-dimagi commented Jan 17, 2025

pm-dimagi commented Jan 17, 2025

pm-dimagi commented Jan 17, 2025

OrangeAndGreen left a comment

OrangeAndGreen Jan 17, 2025

OrangeAndGreen Jan 17, 2025

Pm Dummy PR #2942

Are you sure you want to change the base?

Pm Dummy PR #2942

Conversation

pm-dimagi commented Jan 16, 2025 • edited Loading

Summary

Feature Flag

Product Description

PR Checklist

Automated test coverage

Safety story

pm-dimagi commented Jan 16, 2025

coderabbitai bot commented Jan 16, 2025

Walkthrough

Sequence Diagram

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

pm-dimagi commented Jan 16, 2025

ctsims commented Jan 17, 2025

pm-dimagi commented Jan 17, 2025

pm-dimagi commented Jan 17, 2025

pm-dimagi commented Jan 17, 2025

OrangeAndGreen left a comment

Choose a reason for hiding this comment

OrangeAndGreen Jan 17, 2025

Choose a reason for hiding this comment

OrangeAndGreen Jan 17, 2025

Choose a reason for hiding this comment

pm-dimagi commented Jan 16, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)