Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCCT-483 || User Deactivate Flow (New Revamp) #2866

Merged
merged 4 commits into from
Oct 4, 2024

Conversation

j13panchal
Copy link

Summary

https://dimagi.atlassian.net/browse/CCCT-483

Feature Flag

Product Description

Safety Assurance

  • If the PR is high risk, "High Risk" label is set
  • I have confidence that this PR will not introduce a regression for the reasons below
  • Do we need to enhance manual QA test coverage ? If yes, "QA Note" label is set correctly

Automated test coverage

Safety story

Set User Deacticate flow in new Revamp
User deactivate flow in new Ravamp
Translation added
Copy link
Contributor

@OrangeAndGreen OrangeAndGreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few improvements to make, mostly related to user messaging in the non-greenlight paths.

app/src/org/commcare/connect/ConnectConstants.java Outdated Show resolved Hide resolved
app/res/navigation/nav_graph_connectid.xml Outdated Show resolved Hide resolved
app/res/values/strings.xml Outdated Show resolved Hide resolved
app/res/values/strings.xml Outdated Show resolved Hide resolved
Resolved comments
@OrangeAndGreen OrangeAndGreen merged commit 84a508f into connect_qa Oct 4, 2024
@OrangeAndGreen OrangeAndGreen deleted the jp/user-deactivation-flow-new-revamp branch October 4, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants