-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: available Font Family Regression #2731
fix: available Font Family Regression #2731
Conversation
|
@diegomura tagging to notify that this fixes a recent regression. Please let me know if you need anything else with this. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
My project has v3.4.4 and I just dug through my node modules to find that these changes aren't in the latest release. Please halp! |
@coren-frankel these changes are merged, but they won't be available until @diegomura releases the next version. |
FYI -- this change causes the following failure for me if
The fix that worked for me is:
|
Changes in #2640 caused a regression by not providing proper support for font families made available within the library. This has caused any font families that are built-in to the library to default to Helvetica.
Changes
run.attributes.font
as an array so any strings properlygetOrCreateFont
their associated fonts.Related
Issue: #2730
Example
Before the change:
After the change: