-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add fallback font support #2640
Conversation
🦋 Changeset detectedLatest commit: 90a17da The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
a23eb9d
to
4e6fbab
Compare
Looking forward to getting this merged! 🚀 |
hey @diegomura, wanted to ping and ask if you have some time to review this PR it in the near future |
This would be really useful to be merged ! |
4e6fbab
to
c84cd80
Compare
@nikgraf Should we also update the types package to allow an array of strings for |
@hendrikmolder definitely, will do as soon as there is any sign that the author is interested to merge it |
Hi @nikgraf ! Thanks for working on this and sorry for the silence. Not usually easy to find the time unfortunately. If you can submit the types update I promise I'll review this in a timely manner. |
c84cd80
to
90a17da
Compare
@diegomura types are updated, I force pushed my branch |
Thanks!! |
Thank you @diegomura! This is such a fantastic library. Great job! |
Hey, realised we didn't bump the types package – #2723 |
Allows to add multiple fallback fonts and will fall back to the next font and eventually last font in case the glyph is not available.
I added an example for testing:
Happy to update the PR in case something is missing e.g. test. Just need to know what and where.