-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ROCES and NCES2 #511
Merged
Merged
Add ROCES and NCES2 #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alkidbaci
reviewed
Jan 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's quiet a large amount of changes. Overall things look good. I have a few comments on this PR:
- Add the boolean argument
return_node
to the methodbest_hypotheses
where user can select to return the node or the CE (the return type should also be updated). I noticed that you save the nodes in the class argumentbest_predictions
but in order to keep the same signature for this method throughout our learning models I recommend updating it. - You have 2 implementations for static method
generate_training_data
which are very similar. You can optimize this current state by merging them into a single method and it can be moved tonces_utils.py
. - Please add docstrings for every method\class that does not inherit any docstring from a base class. This information shows in the API at our docs and it helps everyone into better understanding your code and how they can use it.
@alkidbaci please review it |
…g_cv_evaluation.py script
alkidbaci
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both ROCES and NCES2 are integrated in Ontolearn now.
What is left?:
Train NCES2 and ROCES and upload pretrained models to dice-files-system.