-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merging TripleStore and TripleStroreKnowledgeBase, Refactoring and Documentation update #510
Conversation
… TripleStoreReasonerOntology
I have marked some methods on the |
# Conflicts: # ontolearn/abstracts.py # ontolearn/concept_learner.py
After merge with Jean's changes (PR #511), this PR was tested locally because https://files.dice-research.org/ is currently down.
@Demirrr I would like to merge this PR but the merging is blocked because it requires 1 approving review. Error documentation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alkidbaci thank you for the work!
Refactoring
KnowledgeBase
class:ontologymanager_factory
,length_metric_factory
,length_metric
,individuals_cache_size
,ind_set
,backend_store
. Reasons given below, most of them based on 'TODOs' set in the code.all_individuals_set
,get_leaf_concepts
,get_least_general_named_concepts
are removed.encode_learning_problem
disentangled from KB, implementation moved toencode_kb
method of classPosNegLPStandard
.evaluate_concept
disentangled from KB, this method is now moved toquality_funcs.py
moduleget_most_general_classes
renamed tomost_general_classes
are_owl_concept_disjoint
Expanded
AbstractKnowledgeBase
:AbstractKnowledgeBase
. This are methods implemented in KnowledgeBase that weren't part of AbstractKnowledgeBase.Refactoring of related modules:
KnowledgeBase
set toAbstractKnowledgeBase
where applicable (mainly on learning models)Merged
TripleStore
withTripleStoreKnowlegeBase
#451AbstractKnowledgeBase
.TripleStoreKnowledgeBase
removed,TripleStore
now represents both of them.TripleStoreReasonerOntology
removed.TripleStore
now contains a reasoner and an ontology, respectivelyTripleStoreReasoner
andTripleStoreOntology
.AbstractKnowledgeBase
. Some are marked with << REVIEW >>, the reason explained via comments.data_property_ranges
forTripleStoreReasoner
.Validation of changes
TripleStore
, I manually tested different concept learners. Using the scriptexamples/concept_learning_via_triplestore_example.py
anyone can do so. Concept learners work fine with a few exceptions:TripleStore
because of the issue mentioned at Bug with confusion matrix construction for Drill #509.TripleStore
norKnowledgeBase
but the error is unrelated to the changes of this PR.Documentation Update