Unify Arrow and Elemental Arrow Logic #6373
Draft
+174
−173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any idea why it's breaking the demo? |
No :( |
|
Might just be because it was forked from a point where the test was broken in master. A rebase/merge should fix it. |
4564599 to
2cece1a
Compare
|
Did my best to rebase, please test and fix any issues i might have caused :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on: #6336 which moves missile damage into the Add functions from the Process functions
Previously, Arrow missiles and Elemental Arrow missiles were handled with separate functions. This moves Elemental Arrow logic into
AddArrow()andProcessArrow().