Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update: User inter-canister calls [SDK-702] #6
update: User inter-canister calls [SDK-702] #6
Changes from 11 commits
240420f
f82f13b
ef7670b
4756abb
43e97e8
67d7754
0ee5d2f
f1f3200
799c022
3c4d954
806a3d6
f6d0df8
1329a33
0589df4
6b06a83
2b06fa5
f2ed80d
81371eb
a793faa
999dff8
a13658c
2fc89ad
666c0df
16f257e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a gaping security hole: The Blob hash is not a cryptographic one, and (especially with user-picked identities) easy to create collisions for.
I think you simply want the
PrincipalId
to be the blob (or the new abstractPrincipalId
created in dfinity/motoko#1128)