update: User inter-canister calls [SDK-702] #6
Conversation
There was a problem hiding this comment.
Looking really good thus far.
I noticed that you reverted back to hashMap's keys as blob-hashes, rather than the blobs themselves. I assume that's related to some other blocking issue, and not because you decided against that design (the code is still there, but commented).
My comments within the code are about using Option.unwrap, and about some thoughts about making things fancier that come up during the demos. Nothing above is urgent.
src/profile/main.mo
Outdated
|
|
||
| let adminIds : [PrincipalId] = []; | ||
|
|
||
| func getUserId (caller : Blob) : PrincipalId { Blob.hash(caller) }; |
There was a problem hiding this comment.
This is a gaping security hole: The Blob hash is not a cryptographic one, and (especially with user-picked identities) easy to create collisions for.
I think you simply want the PrincipalId to be the blob (or the new abstract PrincipalId created in dfinity/motoko#1128)
|
I'll keep this branch up to date with the latest DFX from source. Is this something we want in Master @stanleygjones ? |
|
Oh sorry, I didn't realize people were commenting on this PR. I hadn't meant to ignore all of your comments. I'll try to incorporate them and get this merged. |
|
Finally got checks passing so let's review this puppy. |
|
Finally got checks passing so let's review this puppy. |
Overview
Still a work in progress. Want to show where my head's at.This PR adds inter-canister calling to the LinkedUp app, and a whole lot of other stuff (basically everything necessary to get the demo working for Davos).
Note: This app will get another round of cleanup before being moved into the Examples repo.
Changes