Using upper case output for the CRC #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems like a lowercase CRC suffix for the canister ID leads to problems when trying to follow the url. It should probably be uppercase by default.
nomeata
approved these changes
Jun 10, 2020
|
closes #29 |
|
Hey guys! Just so you know this will go away later today or Thursday when we release 0.5.8. You can now do |
|
Great to hear! I saw Yan just clicking the output of the ID from dfx after calling ‘dfx canister install‘ in his terminal during the workshop – will this work too? |
|
Yes it will! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like a lowercase CRC suffix for the canister ID leads to problems when trying to follow the url. It should probably be uppercase by default.