Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: CRC could be lowercase, which does not work #29

Open
ninegua opened this issue Apr 25, 2020 · 1 comment
Open

bug: CRC could be lowercase, which does not work #29

ninegua opened this issue Apr 25, 2020 · 1 comment

Comments

@ninegua
Copy link
Member

ninegua commented Apr 25, 2020

The python oneliner in README computes CRC, but if the result contains lower-case letter, it will not be recognized as a valid CanisterId, which leads to the following error when visiting the page in browser:

An error happened:
fromText@http://127.0.0.1:8080/index.js:2:21406
query@http://127.0.0.1:8080/index.js:2:142932
retrieveAsset@http://127.0.0.1:8080/index.js:2:143045
_loadJs@http://127.0.0.1:8080/index.js:2:89546
_main@http://127.0.0.1:8080/index.js:2:90616
@http://127.0.0.1:8080/index.js:2:91079
r@http://127.0.0.1:8080/index.js:2:358
@http://127.0.0.1:8080/index.js:2:1157
@http://127.0.0.1:8080/index.js:2:1167
@http://127.0.0.1:8080/index.js:2:158
@http://127.0.0.1:8080/index.js:2:223
@ninegua
Copy link
Member Author

ninegua commented Apr 25, 2020

I also think we need better error message for an invalid CanisterId. Probably something in the userlib is not handling the response correctly. @hansl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant