Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(node): update-config.service #2393

Merged
merged 120 commits into from
Dec 4, 2024
Merged

feat(node): update-config.service #2393

merged 120 commits into from
Dec 4, 2024

Conversation

andrewbattat
Copy link
Member

@andrewbattat andrewbattat commented Nov 1, 2024 •
edited
Loading

NODE-1493

update-config.service updates the old ic-os config format to the new ic-os config format: #1539

Once all node have an updated version of the config, we will be able to switch nodes to actually use the new config format. Then, once stable, we will delete update-config.service

I've successfully tested on farm and bare metal 🥳

@andrewbattat andrewbattat changed the title Andrew/update config service feat(NODE-1493): update-config.service Nov 4, 2024
@github-actions github-actions bot added the feat label Nov 4, 2024
@andrewbattat andrewbattat self-assigned this Nov 4, 2024
@andrewbattat
Fix deterministic_ips main.rs
61b179f
@andrewbattat
Remove DeploymentEnvironmentArg
79cb8cd
@andrewbattat
Fix nested test driver
a3e6994
@andrewbattat
Replace HwAddr with MacAddr6 in farm
f27312a
@andrewbattat
Fix call to calculate_deterministic_mac
cf27ca7
@andrewbattat
Fix buildifier
fcb5270
@andrewbattat
Remove format_mac_address
79ad7a0
@andrewbattat
Revert to use into in calculate_deterministic_mac
f845264
@andrewbattat
Remove typed parsing of DeploymentEnvironment
724c6c8
@andrewbattat
Remove node_type parsing
ed400f2
@andrewbattat
Hard-type NodeType in deterministic_ips clap
a0467ce
@andrewbattat
Refactor calculate_slaac, create prefix_octets
9bfee74
@andrewbattat
Add description for node_type
b4e7b10
@andrewbattat
Small updates
f25afe9
@andrewbattat
Add display for NodeType and hard-type NodeType in os_tool clap
2fd14e0
@andrewbattat
Merge branch 'andrew/refactor-deterministic-ips' into andrew/update-c…
5d02f05 
…onfig-service
@andrewbattat
Fix update-config after deterministic_ips updates
12b5a14
@andrewbattat
Merge branch 'master' into andrew/update-config-service
7719687
@andrewbattat andrewbattat marked this pull request as ready for review December 4, 2024 07:16
Bownairo
Bownairo approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@Bownairo Bownairo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments, looks good! Let's get this out so we can start logging.

@andrewbattat andrewbattat added this pull request to the merge queue Dec 4, 2024
Merged via the queue into master with commit b6e0faa Dec 4, 2024
24 checks passed
@andrewbattat andrewbattat deleted the andrew/update-config-service branch December 4, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bownairo Bownairo Bownairo approved these changes

Assignees

@andrewbattat andrewbattat

Labels
feat @node
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewbattat @Bownairo