feat(NODE-1475): Configuration revamp (define config structure and config tool) #1539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankdavid
reviewed
Sep 18, 2024
frankdavid
approved these changes
Sep 18, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 4, 2024
NODE-1493 update-config.service updates the old ic-os config format to the new ic-os config format: #1539 Once all node have an updated version of the config, we will be able to switch nodes to _[actually use](#1563 the new config format. Then, once stable, we will delete update-config.service I've successfully tested on farm and bare metal 🥳 --------- Co-authored-by: IDX GitHub Automation <infra+github-automation@dfinity.org>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 8, 2025
NODE-1360 The IC-OS tool has been created, but not yet used by the IC-OS: #1539 This PR integrates the config tool into SetupOS. The config tool is utilized for config sanitization, organization, and access. Note that the *old* config is still being passed to HostOS, so this PR should have no impact on HostOS or GuestOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NODE-1360
Changes pulled out of: #1190
This PR defines the config structure and config tool, but does not yet integrate the config tool into SetupOS. This PR should not have an impact on the ic-os. Later, the config tool will be utilized for config sanitization, organization, access, and propagation.