Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: initialize this repo #11

Closed
wants to merge 51 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
51 commits
Select commit Hold shift + click to select a range
4e5c730
feat: add commitlint to ensure this repo's commit messages follow con…
gobengo Aug 26, 2020
943add0
ci: add .mergify.yml to opt-in to Mergify and re-enable matrix ci tes…
gobengo Aug 26, 2020
f44a182
docs: README describes mergify (#3)
gobengo Aug 26, 2020
d78f77a
docs: small README change just to test mergify (#6)
gobengo Aug 26, 2020
b8e874d
feat: add packages/bootstrap (from sdk:src/bootstrap) (#7)
gobengo Aug 26, 2020
d05cf86
fix: bootstrap package deps on @dfinity/agent via package.json (#8)
gobengo Aug 26, 2020
caaaf5d
wip publish
gobengo Aug 26, 2020
6ea331a
chore: wip publish
gobengo Aug 26, 2020
7432971
ci: add .github/workflows/npm-publish.yml
gobengo Aug 26, 2020
ecd700f
docs: touch readme
gobengo Aug 26, 2020
9f8f9c3
chore: release new versions
github-actions[bot] Aug 26, 2020
498f18f
chore: lerna.json version message includes the new version in commit …
gobengo Aug 26, 2020
a7afc15
docs: touch agent readme
gobengo Aug 26, 2020
94e00dd
chore: commit version v0.7.0-alpha.1
github-actions[bot] Aug 26, 2020
ed7e404
ci: npm-publish workflow does lerna version with --create-release github
gobengo Aug 26, 2020
91342df
chore: noop
gobengo Aug 26, 2020
d60aec7
chore: commit version v0.7.0-alpha.2
github-actions[bot] Aug 26, 2020
d6ef7f5
ci: dont prerelease on every master commit. Make it a manual action
gobengo Aug 26, 2020
394e1a2
Merge branch 'master' of github.com:dfinity-lab/agent-js
gobengo Aug 26, 2020
2576539
chore: commit version v0.7.0-alpha.3
github-actions[bot] Aug 26, 2020
a3e23ee
ci: add release github workflow
gobengo Aug 26, 2020
bbbb4c6
Merge branch 'master' of github.com:dfinity-lab/agent-js
gobengo Aug 26, 2020
2451734
chore: commit version v0.7.0-alpha.4
github-actions[bot] Aug 26, 2020
b2d7180
ci: single release workflow
gobengo Aug 27, 2020
c20f937
Merge branch 'master' of github.com:dfinity-lab/agent-js
gobengo Aug 27, 2020
85cdf51
fix: set up tsc project references so building bootstrap ensures agen…
gobengo Aug 28, 2020
0ca5269
ci: add npm prepare script to agent, bootstrap
gobengo Aug 28, 2020
e88fd2e
chore: remove lerna for now. we don't need it, and its hard to nix bu…
gobengo Aug 31, 2020
07906e8
fix: remove npm prepare script
gobengo Sep 1, 2020
2684726
chore: remove root package.json
gobengo Sep 1, 2020
a737f1b
chore: reintroduce top level package to appease napalm
gobengo Sep 1, 2020
c8a44f0
ci: bump
gobengo Sep 1, 2020
373eb2e
chore: clean up before code review
gobengo Sep 1, 2020
6da3e0a
fix: update package-lock.json
gobengo Sep 2, 2020
377b829
fix: add 0.0.0 version numbers to packages/*/package.json
gobengo Sep 2, 2020
38d47f8
Add bin/for-each-package util
gobengo Sep 2, 2020
f82191e
rm bin/import-*
gobengo Sep 8, 2020
65878ed
rm commitlint.config.js
gobengo Sep 8, 2020
7112caa
root package.json is now private and version=0.0.0
gobengo Sep 8, 2020
6ace900
LICENSE as Apache-2.0
gobengo Sep 8, 2020
c8773dc
reword packages/agent/README.md
gobengo Sep 8, 2020
7e22e2c
packages/bootstrap is npm private
gobengo Sep 8, 2020
4f8d171
remove unnecessary github workflows
gobengo Sep 8, 2020
6ab37fe
Describe bin/* scripts in README
gobengo Sep 8, 2020
f16d364
rm packages/bootstrap/README.html, which shouldnt be there
gobengo Sep 8, 2020
cca8d02
agent-js-devtools deps on webpack
gobengo Sep 9, 2020
2dfe72f
packages/bootstrap npm build script calls webpack
gobengo Sep 9, 2020
56c0946
Never use npx in npm scripts
gobengo Sep 9, 2020
c435842
rm package-lock.json in packages
gobengo Sep 9, 2020
5799552
move css-loader to dep of packages/bootstrap and update package-lock.…
gobengo Sep 9, 2020
2cb791e
Remove mentions of lerna from the README
gobengo Sep 9, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions .github/workflows/conventional-commits.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
name: Check PR title
on:
pull_request:
types:
- opened
- reopened
- edited
- synchronize

jobs:
check:
runs-on: ubuntu-latest
steps:
- uses: hansl/conventional-pr-title-action@v2.2.0
with:
success-state: Title follows the specification.
failure-state: Title does not follow the specification.
context-name: conventional-pr-title
preset: conventional-changelog-angular@latest
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,6 @@ jobs:
# The test beforehand won't do it if the relevant subpackge's ndoe_modules were already fetched.
run: "[ -d packages/agent/node_modules ] || npm run postinstall"
- run: npm run build --if-present
- run: ls node_modules
- run: ls node_modules/.bin
- run: ls packages
- run: ls packages/agent
# - run: (cd packages/)
- run: npm test
env:
CI: true
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ logs
npm-debug.log*
yarn-debug.log*
yarn-error.log*
lerna-debug.log*

# Diagnostic reports (https://nodejs.org/api/report.html)
report.[0-9]*.[0-9]*.[0-9]*.[0-9]*.json
Expand Down
29 changes: 29 additions & 0 deletions .mergify.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
pull_request_rules:
- name: Automatic merge
conditions:
- "#approved-reviews-by>=1"
- "#changes-requested-reviews-by=0"
- status-success=conventional-pr-title
- label=automerge-squash
actions:
merge:
method: squash
strict: smart
commit_message: title+body
delete_head_branch: {}

- name: Clean up automerge tags
conditions:
- closed
actions:
label:
remove:
- automerge-squash

- name: Auto-approve auto-PRs
conditions:
- author=dfinity-bot
actions:
review:
type: APPROVE
message: This bot trusts that bot
201 changes: 201 additions & 0 deletions LICENSE
Original file line number Diff line number Diff line change
@@ -0,0 +1,201 @@
Apache License
Version 2.0, January 2004
http://www.apache.org/licenses/

TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION

1. Definitions.

"License" shall mean the terms and conditions for use, reproduction,
and distribution as defined by Sections 1 through 9 of this document.

"Licensor" shall mean the copyright owner or entity authorized by
the copyright owner that is granting the License.

"Legal Entity" shall mean the union of the acting entity and all
other entities that control, are controlled by, or are under common
control with that entity. For the purposes of this definition,
"control" means (i) the power, direct or indirect, to cause the
direction or management of such entity, whether by contract or
otherwise, or (ii) ownership of fifty percent (50%) or more of the
outstanding shares, or (iii) beneficial ownership of such entity.

"You" (or "Your") shall mean an individual or Legal Entity
exercising permissions granted by this License.

"Source" form shall mean the preferred form for making modifications,
including but not limited to software source code, documentation
source, and configuration files.

"Object" form shall mean any form resulting from mechanical
transformation or translation of a Source form, including but
not limited to compiled object code, generated documentation,
and conversions to other media types.

"Work" shall mean the work of authorship, whether in Source or
Object form, made available under the License, as indicated by a
copyright notice that is included in or attached to the work
(an example is provided in the Appendix below).

"Derivative Works" shall mean any work, whether in Source or Object
form, that is based on (or derived from) the Work and for which the
editorial revisions, annotations, elaborations, or other modifications
represent, as a whole, an original work of authorship. For the purposes
of this License, Derivative Works shall not include works that remain
separable from, or merely link (or bind by name) to the interfaces of,
the Work and Derivative Works thereof.

"Contribution" shall mean any work of authorship, including
the original version of the Work and any modifications or additions
to that Work or Derivative Works thereof, that is intentionally
submitted to Licensor for inclusion in the Work by the copyright owner
or by an individual or Legal Entity authorized to submit on behalf of
the copyright owner. For the purposes of this definition, "submitted"
means any form of electronic, verbal, or written communication sent
to the Licensor or its representatives, including but not limited to
communication on electronic mailing lists, source code control systems,
and issue tracking systems that are managed by, or on behalf of, the
Licensor for the purpose of discussing and improving the Work, but
excluding communication that is conspicuously marked or otherwise
designated in writing by the copyright owner as "Not a Contribution."

"Contributor" shall mean Licensor and any individual or Legal Entity
on behalf of whom a Contribution has been received by Licensor and
subsequently incorporated within the Work.

2. Grant of Copyright License. Subject to the terms and conditions of
this License, each Contributor hereby grants to You a perpetual,
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
copyright license to reproduce, prepare Derivative Works of,
publicly display, publicly perform, sublicense, and distribute the
Work and such Derivative Works in Source or Object form.

3. Grant of Patent License. Subject to the terms and conditions of
this License, each Contributor hereby grants to You a perpetual,
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
(except as stated in this section) patent license to make, have made,
use, offer to sell, sell, import, and otherwise transfer the Work,
where such license applies only to those patent claims licensable
by such Contributor that are necessarily infringed by their
Contribution(s) alone or by combination of their Contribution(s)
with the Work to which such Contribution(s) was submitted. If You
institute patent litigation against any entity (including a
cross-claim or counterclaim in a lawsuit) alleging that the Work
or a Contribution incorporated within the Work constitutes direct
or contributory patent infringement, then any patent licenses
granted to You under this License for that Work shall terminate
as of the date such litigation is filed.

4. Redistribution. You may reproduce and distribute copies of the
Work or Derivative Works thereof in any medium, with or without
modifications, and in Source or Object form, provided that You
meet the following conditions:

(a) You must give any other recipients of the Work or
Derivative Works a copy of this License; and

(b) You must cause any modified files to carry prominent notices
stating that You changed the files; and

(c) You must retain, in the Source form of any Derivative Works
that You distribute, all copyright, patent, trademark, and
attribution notices from the Source form of the Work,
excluding those notices that do not pertain to any part of
the Derivative Works; and

(d) If the Work includes a "NOTICE" text file as part of its
distribution, then any Derivative Works that You distribute must
include a readable copy of the attribution notices contained
within such NOTICE file, excluding those notices that do not
pertain to any part of the Derivative Works, in at least one
of the following places: within a NOTICE text file distributed
as part of the Derivative Works; within the Source form or
documentation, if provided along with the Derivative Works; or,
within a display generated by the Derivative Works, if and
wherever such third-party notices normally appear. The contents
of the NOTICE file are for informational purposes only and
do not modify the License. You may add Your own attribution
notices within Derivative Works that You distribute, alongside
or as an addendum to the NOTICE text from the Work, provided
that such additional attribution notices cannot be construed
as modifying the License.

You may add Your own copyright statement to Your modifications and
may provide additional or different license terms and conditions
for use, reproduction, or distribution of Your modifications, or
for any such Derivative Works as a whole, provided Your use,
reproduction, and distribution of the Work otherwise complies with
the conditions stated in this License.

5. Submission of Contributions. Unless You explicitly state otherwise,
any Contribution intentionally submitted for inclusion in the Work
by You to the Licensor shall be under the terms and conditions of
this License, without any additional terms or conditions.
Notwithstanding the above, nothing herein shall supersede or modify
the terms of any separate license agreement you may have executed
with Licensor regarding such Contributions.

6. Trademarks. This License does not grant permission to use the trade
names, trademarks, service marks, or product names of the Licensor,
except as required for reasonable and customary use in describing the
origin of the Work and reproducing the content of the NOTICE file.

7. Disclaimer of Warranty. Unless required by applicable law or
agreed to in writing, Licensor provides the Work (and each
Contributor provides its Contributions) on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
implied, including, without limitation, any warranties or conditions
of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A
PARTICULAR PURPOSE. You are solely responsible for determining the
appropriateness of using or redistributing the Work and assume any
risks associated with Your exercise of permissions under this License.

8. Limitation of Liability. In no event and under no legal theory,
whether in tort (including negligence), contract, or otherwise,
unless required by applicable law (such as deliberate and grossly
negligent acts) or agreed to in writing, shall any Contributor be
liable to You for damages, including any direct, indirect, special,
incidental, or consequential damages of any character arising as a
result of this License or out of the use or inability to use the
Work (including but not limited to damages for loss of goodwill,
work stoppage, computer failure or malfunction, or any and all
other commercial damages or losses), even if such Contributor
has been advised of the possibility of such damages.

9. Accepting Warranty or Additional Liability. While redistributing
the Work or Derivative Works thereof, You may choose to offer,
and charge a fee for, acceptance of support, warranty, indemnity,
or other liability obligations and/or rights consistent with this
License. However, in accepting such obligations, You may act only
on Your own behalf and on Your sole responsibility, not on behalf
of any other Contributor, and only if You agree to indemnify,
defend, and hold each Contributor harmless for any liability
incurred by, or claims asserted against, such Contributor by reason
of your accepting any such warranty or additional liability.

END OF TERMS AND CONDITIONS

APPENDIX: How to apply the Apache License to your work.

To apply the Apache License to your work, attach the following
boilerplate notice, with the fields enclosed by brackets "[]"
replaced with your own identifying information. (Don't include
the brackets!) The text should be enclosed in the appropriate
comment syntax for the file format. We also recommend that a
file or class name and description of purpose be included on the
same "printed page" as the copyright notice for easier
identification within third-party archives.

Copyright 2020 DFINITY LLC.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
37 changes: 15 additions & 22 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,44 +2,37 @@

Use an Agent to interact with the Internet Computer from your JavaScript program.

This source code repository contains multiple npm packages, and [lerna](https://lerna.js.org/) provides tools for managing the monorepo. Currently we use lerna in ['fixed' mode](https://github.com/lerna/lerna#fixedlocked-mode-default), which means all packages are the same version. This may change in the future.
This source code repository contains multiple npm packages, each under `./packages/`.

## Development

### Getting Started

1. Clone the git repository.
2. Run `npm install`
* The npm postinstall script should automatically call `lerna bootstrap`, which will install/link all subpackages.

After that, you probably want to dive into a specific package in [./packages](./packages).

### Cross-Package Commands

Use `npx` to fetch-and/or-invoke the `lerna` CLI (Note: the `lerna` cli is also usually at `./node_modules/.bin/lerna` after `npm install`).

#### Run `npm run test` in all packages.
### GitHub Actions

```
npx lerna run test
```
GitHub Actions for this repo are configured in [./.github/workflows](./.github/workflows).

#### Run `npm run lint` in all packages.
* [nodejs-ci.yml](./.github/workflows/nodejs-ci.yml) - For every git push, do a build, test of all packages.
* [commitlint.yml](./.github/workflows/commitlint.yml) - Run [commitlint](https://commitlint.js.org/#/) on every git commit message.

```
npx lerna run lint
```
### Master Branch Conventions and Mergify

#### Add a new npm dependency to package '@dfinity/agent'
All commits in the master branch should come from squashed GitHub Pull Requests, and those commit messages should follow the [conventionalcommits.org](https://conventionalcommits.org) syntax.

```
npx lerna add dependency-name --scope='@dfinity/agent'
```
Mergify can take care of enforcing all of this. Just add the `automerge-squash` label to each Pull Request that Mergify should merge. This policy is configured via [./.mergify.yml](./.mergify).

### GitHub Actions
### bin/* scripts

GitHub Actions for this repo are configured in [./.github/workflows](./.github/workflows).
The following scripts can be found in [./bin](./bin):

* [push.yml](./.github/workflows/push.yml) - For every git push, do build, test of all packages.
Monorepo-related scripts run in this order, but are usually invoked by `npm install`:

When developing these configuration files, you may test with [nektos/act](https://github.com/nektos/act).
* npm-postinstall - Run with `npm run postinstall` in this monorepo package.
* It copies devtools dependencies from ./packages/agent-js-devtools/node_modules -> ./node_modules
* build - Build (`npm run build`) each subpackage in ./packages/
* test - Run `npm test` in each subpackage
13 changes: 13 additions & 0 deletions bin/build
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
#!/bin/sh

# exit on error
set -e

for package in ./packages/*
do
(
echo "building package: $package"
cd "$package"
npm run build --if-present
)
done
16 changes: 16 additions & 0 deletions bin/npm-postinstall
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
#!/bin/sh

# exit on error
set -e

devtools_node_modules="packages/agent-js-devtools/node_modules"

# Copy npm devtools into ./node_modules.
# Because npm resolves tools in ancestor dirs' node_modules too,
# this should make common devtools like jest/tsc be found when
# run from npm runscripts inside ./packages/*/
if test -d "$devtools_node_modules"; then
cp -R "$devtools_node_modules"/. node_modules/
else
echo "warn: npm-postinstall did not find dir $devtools_node_modules"
fi
13 changes: 13 additions & 0 deletions bin/test
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
#!/bin/sh

# exit on error
set -e

for package in ./packages/*
do
(
echo "testing package: $package"
cd "$package"
npm test
)
done
6 changes: 0 additions & 6 deletions lerna.json

This file was deleted.

Loading