-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: initialize this repo #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ventionalcommits.org gh action push.yml does commitlint chore: log whoami in gh actions to debug failure chore: github action installs git in a way that works with both github and nektos/act (no sudo) fix: commitlint
…ting (#2) * feat: add .mergeify.yml to opt-in to Mergeify * ci: re-enable matrix testing on node 10,12
* feat: add .mergeify.yml to opt-in to Mergeify * ci: re-enable matrix testing on node 10,12 * docs: ./README describes mergify * ci: add conventional-commits github workflow (via agent-rust)
* chore: add bin/import-agent-from to specify the difference between sdk agent and whats in here * feat: import packages/bootstrap from sdk via new ./bin/import-bootstrap-from script
hansl
reviewed
Sep 2, 2020
hansl
reviewed
Sep 2, 2020
hansl
reviewed
Sep 2, 2020
hansl
reviewed
Sep 2, 2020
hansl
reviewed
Sep 2, 2020
hansl
reviewed
Sep 2, 2020
hansl
reviewed
Sep 2, 2020
hansl
reviewed
Sep 2, 2020
hansl
reviewed
Sep 2, 2020
hansl
reviewed
Sep 2, 2020
hansl
reviewed
Sep 2, 2020
packages/bootstrap/README.html
Outdated
@@ -0,0 +1,560 @@ | |||
<!DOCTYPE html> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is tooling output of adoc. Remove.
hansl
reviewed
Sep 2, 2020
hansl
suggested changes
Sep 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few nits but LGTM.
Is this PR still necessary? Is it ready? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is from master into a temporary branch called 'empty' that has no files in it. Hoping it helps with code review.
I've needed to iterate quite a bit in the master branch here while working on dfinity/sdk#981.