-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactored newexp (again) #250
Conversation
This PR has gotten out of hand already. Will merge prior to implementing smaller isolated changes like #221 (Adding support for WD subtypes DA and DB). Running final (?) travis tests now, while checking simulating spectra tutorial in parallel. |
Close notes: This will require minor changes to the simulating spectra tutorial since the return values of I'll also submit an update to the desispec integration test to call quickgen runs and produces working cframe files, but the quicklook integration test fails on the sky subtraction step. It does work on master (after a minor desispec.pipeline.runcmd -> desispec.util.runcmd fix) so I broke something here, but I haven't been able to chase that down yet and don't want that to block this PR.
A few features that I discussed with @moustakas and @akremin that didn't make it in here yet:
|
This is the replacement PR for #238 that got bogged down in rebasing and merge conflicts due to keep the branch and PR open too long. Trying again.
Tests pass on cori; moving on to Travis now. Will also re-confirm with integration tests prior to final merge.