Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: respect preload set to false #1298

Merged
merged 4 commits into from
Jan 7, 2019
Merged

fix: respect preload set to false #1298

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
55fc455
fix: respect preload set to false
jeeyyy Jan 3, 2019
b72ff9b
test: added test cases
jeeyyy Jan 3, 2019
ba567be
Merge branch 'develop' into fix-preloading-assets
jeeyyy Jan 3, 2019
4dda909
Merge branch 'develop' into fix-preloading-assets
WilcoFiers Jan 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/checks/mobile/css-orientation-lock.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
"impact": "serious",
"messages": {
"pass": "Display is operable, and orientation lock does not exist",
"fail": "CSS Orientation lock is applied, and makes display inoperable"
"fail": "CSS Orientation lock is applied, and makes display inoperable",
"incomplete": "CSS Orientation lock cannot be determined"
}
}
}
2 changes: 1 addition & 1 deletion lib/core/utils/preload.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ function isValidPreloadObject(preload) {
* @return {boolean} defaults to true
*/
axe.utils.shouldPreload = function shouldPreload(options) {
if (!options || !options.preload) {
if (!options || options.preload === undefined || options.preload === null) {
return true; // by default `preload` requested assets eg: ['cssom']
}
if (typeof options.preload === 'boolean') {
Expand Down