fix: respect preload set to false #1298
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the below:
Noticed a bug with
shouldPreload
, whenpreload: false
is passed in via options,shouldPreload
returned true (handled by checking for undefined/ null).Say, in cases where
runOnly
is configured to anycssom
related rule likecss-orientation-lock
, butpreload
is set tofalse
, no properincomplete
message was provided.Eg:
The above snippet will return no
assets
such as cssom, aspreload: false
overrides the need to load assets. In this case, there was no helpfulincomplete
message.Closes issue: NA.
Reviewer checks
Required fields, to be filled out by PR reviewer(s)