Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enabled RSpec VerifiedDoubeReference rule #9981

Merged
merged 4 commits into from
Jun 13, 2024
Merged

enabled RSpec VerifiedDoubeReference rule #9981

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d8d34de
enabled RSpec VerifiedDoubeReference rule
GarryHurleyJr Jun 12, 2024
0ee7ba1
enabled RSpec VerifiedDoubeReference rule
GarryHurleyJr Jun 12, 2024
24adb05
Merge branch 'GarryHurleyJr/enableRSpecVerifiedDoubleReference' of ht…
GarryHurleyJr Jun 13, 2024
1ca453b
Merge branch 'main' into GarryHurleyJr/enableRSpecVerifiedDoubleRefer…
GarryHurleyJr Jun 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions .rubocop_todo.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,14 +242,6 @@ RSpec/UnspecifiedException:
Exclude:
- 'updater/spec/dependabot/job_spec.rb'

# Offense count: 3
# This cop supports unsafe autocorrection (--autocorrect-all).
# Configuration parameters: EnforcedStyle.
# SupportedStyles: constant, string
RSpec/VerifiedDoubleReference:
Exclude:
- 'updater/spec/dependabot/updater/operations/refresh_group_update_pull_request_spec.rb'

# Offense count: 26
# Configuration parameters: IgnoreNameless, IgnoreSymbolicNames.
RSpec/VerifiedDoubles:
Expand Down
6 changes: 3 additions & 3 deletions updater/spec/dependabot/updater/operations/refresh_group_update_pull_request_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,15 +272,15 @@
end

let(:group) do
instance_double("Dependabot::DependencyGroup", rules: { "update-types" => update_types })
instance_double(Dependabot::DependencyGroup, rules: { "update-types" => update_types })
end

let(:dependency) do
instance_double("Dependabot::Dependency", version: current_version)
instance_double(Dependabot::Dependency, version: current_version)
end

let(:checker) do
instance_double("Dependabot::UpdateCheckers::Base", latest_version: latest_version)
instance_double(Dependabot::UpdateCheckers::Base, latest_version: latest_version)
end

before do
Expand Down
Loading