Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enabled RSpec VerifiedDoubeReference rule #9981

Merged
merged 4 commits into from
Jun 13, 2024

Conversation

GarryHurleyJr
Copy link
Contributor

@GarryHurleyJr GarryHurleyJr commented Jun 12, 2024

https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/VerifiedDoubleReference

What are you trying to accomplish?

The VerifiedDoubleReference rule was disabled for updater/spec/dependabot/updater/operations/refresh_group_update_pull_request_spec.rb. This PR fixes that exclusion

Anything you want to highlight for special attention from reviewers?

be alert for duplicated lines

How will you know you've accomplished your goal?

The file is changed and the test still works.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@GarryHurleyJr GarryHurleyJr requested a review from a team as a code owner June 12, 2024 15:13
@github-actions github-actions bot added the L: php:composer Issues and code for Composer label Jun 12, 2024
@GarryHurleyJr GarryHurleyJr force-pushed the GarryHurleyJr/enableRSpecVerifiedDoubleReference branch from d8d34de to 0ee7ba1 Compare June 13, 2024 14:59
@GarryHurleyJr GarryHurleyJr merged commit 1a3fd49 into main Jun 13, 2024
121 checks passed
@GarryHurleyJr GarryHurleyJr deleted the GarryHurleyJr/enableRSpecVerifiedDoubleReference branch June 13, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: php:composer Issues and code for Composer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants