Strict type Dependabot::Hex::FileUpdater::NativeHelpers

hex/lib/dependabot/hex/file_updater.rb

@@ -1,23 +1,28 @@
-# typed: true
+# typed: strict
 # frozen_string_literal: true
 
 require "dependabot/file_updaters"
 require "dependabot/file_updaters/base"
 require "dependabot/shared_helpers"
+require "sorbet-runtime"
 
 module Dependabot
   module Hex
     class FileUpdater < Dependabot::FileUpdaters::Base
+      extend T::Sig
+
       require_relative "file_updater/mixfile_updater"
       require_relative "file_updater/lockfile_updater"
 
+      sig { override.returns(T::Array[Regexp]) }
       def self.updated_files_regex
         [
           /^mix\.exs$/,
           /^mix\.lock$/
         ]
       end
 
+      sig { override.returns(T::Array[Dependabot::DependencyFile]) }
       def updated_dependency_files
         updated_files = []
 
@@ -30,40 +35,45 @@ def updated_dependency_files
 
         if lockfile
           updated_files <<
-            updated_file(file: lockfile, content: updated_lockfile_content)
+            updated_file(file: T.must(lockfile), content: updated_lockfile_content)
         end
 
         updated_files
       end
 
       private
 
+      sig { override.void }
       def check_required_files
         raise "No mix.exs!" unless get_original_file("mix.exs")
       end
 
+      sig { params(file: Dependabot::DependencyFile).returns(String) }
       def updated_mixfile_content(file)
         MixfileUpdater.new(
           dependencies: dependencies,
           mixfile: file
         ).updated_mixfile_content
       end
 
+      sig { returns(String) }
       def updated_lockfile_content
-        @updated_lockfile_content ||=
-          LockfileUpdater.new(
-            dependencies: dependencies,
-            dependency_files: dependency_files,
-            credentials: credentials
-          ).updated_lockfile_content
+        @updated_lockfile_content ||= T.let(nil, T.nilable(String))
+        LockfileUpdater.new(
+          dependencies: dependencies,
+          dependency_files: dependency_files,
+          credentials: credentials
+        ).updated_lockfile_content
       end
 
+      sig { returns(T::Array[Dependabot::DependencyFile]) }
       def mixfiles
         dependency_files.select { |f| f.name.end_with?("mix.exs") }
       end
 
+      sig { returns(T.nilable(Dependabot::DependencyFile)) }
       def lockfile
-        @lockfile ||= get_original_file("mix.lock")
+        @lockfile ||= T.let(get_original_file("mix.lock"), T.nilable(Dependabot::DependencyFile))
       end
     end
   end

hex/lib/dependabot/hex/native_helpers.rb

@@ -1,16 +1,22 @@
-# typed: true
+# typed: strong
 # frozen_string_literal: true
 
+require "sorbet-runtime"
+
 module Dependabot
   module Hex
     module NativeHelpers
+      extend T::Sig
+
+      sig { returns(String) }
       def self.hex_helpers_dir
         helpers_root = ENV.fetch("DEPENDABOT_NATIVE_HELPERS_PATH", nil)
         return File.join(helpers_root, "hex") unless helpers_root.nil?
 
         File.join(__dir__, "../../../../hex/helpers")
       end
 
+      sig { params(path: String).returns(String) }
       def self.clean_path(path)
         Pathname.new(path).cleanpath.to_path
       end