Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict type Dependabot::Hex::FileUpdater::NativeHelpers #9976

Merged
merged 3 commits into from
Jun 12, 2024

Conversation

raj-meka
Copy link
Contributor

@raj-meka raj-meka commented Jun 11, 2024

What are you trying to accomplish?

Sorbet Implementation for Hex FileUpdater and NativeHelpers ruby file.

Anything you want to highlight for special attention from reviewers?

Please pay attention to the fixes in the Hex FileUpdater and NativeHelpers ruby file.

How will you know you've accomplished your goal?

The sorbet rules will fire as needed.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@raj-meka raj-meka requested a review from a team as a code owner June 11, 2024 23:50
@raj-meka raj-meka requested a review from JamieMagee June 11, 2024 23:51
@github-actions github-actions bot added the L: elixir:hex Elixir packages via hex label Jun 11, 2024
@raj-meka raj-meka changed the title Strict type Dependabot::Hex::FileUpdater Strict type Dependabot::Hex::FileUpdater::NativeHelpers Jun 12, 2024
@raj-meka raj-meka force-pushed the Strict-type-DependabotHexFileUpdater branch from f131926 to 8f136a2 Compare June 12, 2024 13:40
@JamieMagee JamieMagee added the sorbet 🍦 Relates to Sorbet types label Jun 12, 2024
@raj-meka raj-meka force-pushed the Strict-type-DependabotHexFileUpdater branch from 8f136a2 to 476da31 Compare June 12, 2024 17:49
@raj-meka raj-meka merged commit 921fcff into main Jun 12, 2024
73 checks passed
@raj-meka raj-meka deleted the Strict-type-DependabotHexFileUpdater branch June 12, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: elixir:hex Elixir packages via hex sorbet 🍦 Relates to Sorbet types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants