Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled Rubocop rule for the MetadataStyle test #9921

Merged
merged 1 commit into from
Jun 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions .rubocop_todo.yml
Original file line number Diff line number Diff line change
Expand Up @@ -135,16 +135,6 @@ RSpec/MessageChain:
RSpec/MessageSpies:
Enabled: false

# Offense count: 8
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: EnforcedStyle.
# SupportedStyles: hash, symbol
RSpec/MetadataStyle:
Exclude:
- 'hex/spec/dependabot/hex/update_checker/version_resolver_spec.rb'
- 'terraform/spec/dependabot/terraform/file_parser_spec.rb'
- 'updater/spec/dependabot/file_fetcher_command_spec.rb'

# Offense count: 1
RSpec/MultipleDescribes:
Exclude:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@
context "with a dependency with a bad specification" do
let(:mixfile_fixture_name) { "bad_spec" }

it "raises a DependencyFileNotResolvable error", skip_ci: true do
it "raises a DependencyFileNotResolvable error", :skip_ci do
expect { resolver.latest_resolvable_version }
.to raise_error(Dependabot::DependencyFileNotResolvable)
end
Expand Down
2 changes: 1 addition & 1 deletion terraform/spec/dependabot/terraform/file_parser_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -914,7 +914,7 @@
end
end

context "with a private module proxy that can't be reached", vcr: true do
context "with a private module proxy that can't be reached", :vcr do
before do
artifactory_repo_url = "http://artifactory.dependabot.com/artifactory/tf-modules/azurerm"

Expand Down
12 changes: 6 additions & 6 deletions updater/spec/dependabot/file_fetcher_command_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
Dependabot::Experiments.reset!
end

it "fetches the files and writes the fetched files to output.json", vcr: true do
it "fetches the files and writes the fetched files to output.json", :vcr do
expect(api_client).not_to receive(:mark_job_as_processed)

perform_job
Expand All @@ -56,7 +56,7 @@
expect(dependency_file["content_encoding"]).to eq("utf-8")
end

context "when the fetcher raises a ToolVersionNotSupported error", vcr: true do
context "when the fetcher raises a ToolVersionNotSupported error", :vcr do
before do
allow_any_instance_of(Dependabot::Bundler::FileFetcher)
.to receive(:commit).and_return("a" * 40)
Expand Down Expand Up @@ -124,7 +124,7 @@
end
end

context "when the fetcher raises a file fetcher error (cloud)", vcr: true do
context "when the fetcher raises a file fetcher error (cloud)", :vcr do
before do
allow_any_instance_of(Dependabot::Bundler::FileFetcher)
.to receive(:commit)
Expand Down Expand Up @@ -172,7 +172,7 @@
end
end

context "when the fetcher raises a file fetcher error (ghes)", vcr: true do
context "when the fetcher raises a file fetcher error (ghes)", :vcr do
before do
allow_any_instance_of(Dependabot::Bundler::FileFetcher)
.to receive(:commit)
Expand Down Expand Up @@ -232,7 +232,7 @@
end
end

context "when vendoring dependencies", vcr: true do
context "when vendoring dependencies", :vcr do
let(:job_definition) do
JSON.parse(fixture("jobs/job_with_vendor_dependencies.json"))
end
Expand Down Expand Up @@ -314,7 +314,7 @@
end
end

context "when the connectivity check is enabled", vcr: true do
context "when the connectivity check is enabled", :vcr do
before do
allow(ENV).to receive(:[]).and_call_original
allow(ENV).to receive(:[]).with("ENABLE_CONNECTIVITY_CHECK").and_return("1")
Expand Down
Loading