Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled Rubocop rule for the MetadataStyle test #9921

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

GarryHurleyJr
Copy link
Contributor

@GarryHurleyJr GarryHurleyJr commented Jun 6, 2024

What are you trying to accomplish?

The Rubocop rule to check for MetadataStyle was excluded on several files. This PR will re-enable that issue.

Anything you want to highlight for special attention from reviewers?

Please be on alert for multiple lines doing the same thing.

How will you know you've accomplished your goal?

The rubocop rule will be enforced on the entire application.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@GarryHurleyJr GarryHurleyJr requested a review from a team as a code owner June 6, 2024 17:06
@github-actions github-actions bot added L: elixir:hex Elixir packages via hex L: terraform Terraform packages labels Jun 6, 2024
@GarryHurleyJr GarryHurleyJr merged commit d053780 into main Jun 6, 2024
121 checks passed
@GarryHurleyJr GarryHurleyJr deleted the GarryHurleyJr/enableRSpecMetadata branch June 6, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: elixir:hex Elixir packages via hex L: terraform Terraform packages
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants