Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove code handling pyproject.lock files #7833

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Remove code handling pyproject.lock files #7833

merged 1 commit into from
Aug 18, 2023

Conversation

deivid-rodriguez
Copy link
Contributor

Poetry no longer supports them.

@deivid-rodriguez deivid-rodriguez requested a review from a team as a code owner August 17, 2023 19:48
abdulapopoola
abdulapopoola approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@abdulapopoola abdulapopoola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning all these up!

@deivid-rodriguez
Copy link
Contributor Author

This should get green once rebased over #7832.

@deivid-rodriguez deivid-rodriguez mentioned this pull request Aug 17, 2023
Merged
@deivid-rodriguez deivid-rodriguez force-pushed the deivid-rodriguez/remove-pyproject-lock branch from e625b33 to 11dda5c Compare August 17, 2023 22:22
@deivid-rodriguez @jeffwidman
Remove code handling pyproject.lock files
c4c6b25 
Poetry no longer supports them.
@jeffwidman jeffwidman force-pushed the deivid-rodriguez/remove-pyproject-lock branch from 11dda5c to c4c6b25 Compare August 18, 2023 01:02
jeffwidman
jeffwidman approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member

@jeffwidman jeffwidman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is AWESOME that we can clean this up.

Be great to document (if you happen to know) a reference from upstream poetry that they've dropped support for this.

@jeffwidman jeffwidman enabled auto-merge (squash) August 18, 2023 01:08
@jeffwidman jeffwidman merged commit f7336e6 into main Aug 18, 2023
@jeffwidman jeffwidman deleted the deivid-rodriguez/remove-pyproject-lock branch August 18, 2023 01:23
@deivid-rodriguez
Copy link
Contributor Author

I don't really know it.

The way I discovered this is when I started trying to run poetry show --only main for #7834, and seeing that for some specs this command would complain with an error "No poetry.lock was found". Then I saw that all the specs were actually running with a pyproject.lock file and that poetry was simply ignoring that and running all tests as if there was no lockfile. And that's only what made me find about the bug fixed by #7832.

@deivid-rodriguez deivid-rodriguez mentioned this pull request Aug 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abdulapopoola abdulapopoola abdulapopoola approved these changes

@jeffwidman jeffwidman jeffwidman approved these changes

Assignees
No one assigned
Labels
L: python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deivid-rodriguez @jeffwidman @abdulapopoola