Fix yanked library problems in Poetry not detected when lockfile is present #7832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdulapopoola
approved these changes
Aug 17, 2023
e12017e to
61cab10
Compare
This was referenced Aug 17, 2023
61cab10 to
b3761d0
Compare
I trust ya, but when I tried to verify I couldn't find a commit/PR removing support for this... is this something that landed in If you have a reference close at hand be great to include it, if not, no worries, I gave up after 5 mins of spelunking and decided it wasn't worth digging further. |
jeffwidman
approved these changes
Aug 18, 2023
|
Same as #7833 (comment). I didn't really check poetry upstream at all, just observed the current behavior of Poetry 1.5.1 which is the only version we use at the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests updated in this PR were using a legacy
pyproject.lockfile, which is currently ignored by poetry 1.5. So the tests were unintentionally exercising the no-lockfile case and Dependabot was not behaving properly for the lockfile case.This PR only fixes this bug but I will follow up with another PR to completely remove code dealing with
pyproject.lockfiles.