Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop pinning wheel #7784

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Stop pinning wheel #7784

merged 1 commit into from
Aug 10, 2023

Conversation

jeffwidman
Copy link
Member

We've gone back and forth on this repeatedly:

As @yeikel pointed out, if we're going to keep pinning this, we really ought to have CI that checks it in some way (although that'd potentially be tricky as we want to not only test on latest python, but also oldest python).

As Deivid pointed out though, it's not really providing a lot of benefit for us to pin... simpler to just let pip pick whatever it needs and keep going.

If we observe breakage, we can start pinning again. Although probably (hopefully) that'd be very infrequent, and it'd be only a temporary thing until upstream fixes their bug and releases a new version then we can drop the pin. Or in that case I'd probably actually expect pip-tools to handle the work of temp-pinning as they're the ones who need it.

Copy link
Contributor

@yeikel yeikel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be fine as that all our tests are passing. If any regression is introduced the plan that you mentioned should work

We've gone back and forth on this repeatedly:
* #5597
* #7748 (comment)

As @yeikel pointed out, if we're going to keep pinning this, we really ought to have CI that checks it in some way (although that'd potentially be tricky as we want to not only test on latest python, but also oldest python).

As Deivid pointed out though, it's not really providing a lot of benefit for us to pin... simpler to just let `pip` pick whatever it needs and keep going.

If we observe breakage, we can start pinning again. Although probably (hopefully) that'd be very infrequent, and it'd be only a temporary thing until upstream fixes their bug and releases a new version then we can drop the pin. Or in that case I'd probably actually expect `pip-tools` to handle the work of temp-pinning as they're the ones who need it.
@jeffwidman jeffwidman enabled auto-merge (squash) August 10, 2023 16:13
@jeffwidman jeffwidman merged commit 8b10618 into main Aug 10, 2023
@jeffwidman jeffwidman deleted the stop-pinning-wheel branch August 10, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants