Skip to content

Commit

Permalink
Stop pinning wheel
Browse files Browse the repository at this point in the history
We've gone back and forth on this repeatedly:
* #5597
* #7748 (comment)

As @yeikel pointed out, if we're going to keep pinning this, we really ought to have CI that checks it in some way (although that'd potentially be tricky as we want to not only test on latest python, but also oldest python).

As Deivid pointed out though, it's not really providing a lot of benefit for us to pin... simpler to just let `pip` pick whatever it needs and keep going.

If we observe breakage, we can start pinning again. Although probably (hopefully) that'd be very infrequent, and it'd be only a temporary thing until upstream fixes their bug and releases a new version then we can drop the pin. Or in that case I'd probably actually expect `pip-tools` to handle the work of temp-pinning as they're the ones who need it.
  • Loading branch information
jeffwidman committed Aug 10, 2023
1 parent cb26c07 commit f61bee4
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions python/helpers/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ hashin==0.17.0
pipenv==2022.4.8
pipfile==0.0.2
poetry>=1.1.15,<1.6.0
# For now we chose to pin `wheel` even though we don't import it directly.
# Background context: https://github.com/dependabot/dependabot-core/pull/5597
wheel==0.37.1

# Some dependencies will only install if Cython is present
Cython==3.0.0

0 comments on commit f61bee4

Please sign in to comment.