Removes YarnLockfileParser
#6016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YarnLockfileParser is a vestige from an era in which it may have been safer to parse a yarn.lock ourselves rather than shelling out to a native helper. Elsewhere Dependabot uses a native helper, `yarn:parseLockfile` (which in turn uses Yarn's own lockfile parser) to parse yarn lockfiles. Since the YarnLockfileParser is no longer required, and in order to parse lockfiles consistently, the class is being removed.
Merged
thavaahariharangit
pushed a commit
that referenced
this pull request
May 13, 2024
thavaahariharangit
added a commit
that referenced
this pull request
May 13, 2024
#6016: Address RSpec/ContextMethod Rubocop violations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YarnLockfileParseris a vestige from an era in which it may have been safer to parse a yarn.lock ourselves rather than shelling out to yarn. Elsewhere Dependabot uses a native helper,yarn:parseLockfile(which in turn uses Yarn's own lockfile parser) to parse yarn lockfiles. SinceYarnLockfileParseris no longer needed, and in order to parse lockfiles consistently, this PR removes it.