#6016: Address RSpec/ContextMethod Rubocop violations

dependabot · May 13, 2024 · 59380e5 · 59380e5
1 parent 184c192
commit 59380e5
Show file tree

Hide file tree

Showing 7 changed files with 8 additions and 19 deletions.
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
@@ -69,17 +69,6 @@ RSpec/ContainExactly:
   Exclude:
     - 'npm_and_yarn/spec/dependabot/npm_and_yarn/update_checker_spec.rb'
 
-# Offense count: 8
-# This cop supports safe autocorrection (--autocorrect).
-RSpec/ContextMethod:
-  Exclude:
-    - 'cargo/spec/dependabot/cargo/update_checker_spec.rb'
-    - 'composer/spec/dependabot/composer/update_checker_spec.rb'
-    - 'npm_and_yarn/spec/dependabot/npm_and_yarn/update_checker/version_resolver_spec.rb'
-    - 'npm_and_yarn/spec/dependabot/npm_and_yarn/update_checker_spec.rb'
-    - 'nuget/spec/dependabot/nuget/update_checker/compatibility_checker_spec.rb'
-    - 'python/spec/dependabot/python/update_checker_spec.rb'
-
 # Offense count: 2237
 # Configuration parameters: Prefixes, AllowedPatterns.
 # Prefixes: when, with, without

diff --git a/cargo/spec/dependabot/cargo/update_checker_spec.rb b/cargo/spec/dependabot/cargo/update_checker_spec.rb
@@ -489,7 +489,7 @@
     end
   end
 
-  context "#requirements_unlocked_or_can_be?" do
+  describe "#requirements_unlocked_or_can_be?" do
     subject { checker.requirements_unlocked_or_can_be? }
 
     it { is_expected.to eq(true) }

diff --git a/composer/spec/dependabot/composer/update_checker_spec.rb b/composer/spec/dependabot/composer/update_checker_spec.rb
@@ -881,7 +881,7 @@
     end
   end
 
-  context "#requirements_unlocked_or_can_be?" do
+  describe "#requirements_unlocked_or_can_be?" do
     subject { checker.requirements_unlocked_or_can_be? }
 
     it { is_expected.to eq(true) }

diff --git a/npm_and_yarn/spec/dependabot/npm_and_yarn/update_checker/version_resolver_spec.rb b/npm_and_yarn/spec/dependabot/npm_and_yarn/update_checker/version_resolver_spec.rb
@@ -1774,7 +1774,7 @@
       end
     end
 
-    context "#dependency_updates_from_full_unlock resolves previous version" do
+    describe "#dependency_updates_from_full_unlock resolves previous version" do
       let(:project_name) { "npm6/exact_version_requirements_no_lockfile" }
       subject do
         resolver.dependency_updates_from_full_unlock.first[:previous_version]
@@ -1811,7 +1811,7 @@
       it { is_expected.to eq("0.3.0") }
     end
 
-    context "#latest_resolvable_previous_version" do
+    describe "#latest_resolvable_previous_version" do
       let(:project_name) { "npm6/exact_version_requirements_no_lockfile" }
       subject do
         resolver.latest_resolvable_previous_version(latest_allowable_version)

diff --git a/npm_and_yarn/spec/dependabot/npm_and_yarn/update_checker_spec.rb b/npm_and_yarn/spec/dependabot/npm_and_yarn/update_checker_spec.rb
@@ -1200,7 +1200,7 @@
     end
   end
 
-  context "#requirements_unlocked_or_can_be?" do
+  describe "#requirements_unlocked_or_can_be?" do
     subject { checker.requirements_unlocked_or_can_be? }
 
     it { is_expected.to eq(true) }
@@ -1212,7 +1212,7 @@
     end
   end
 
-  context "#updated_dependencies_after_full_unlock" do
+  describe "#updated_dependencies_after_full_unlock" do
     let(:dependency_files) { project_dependency_files("npm6/no_lockfile") }
     let(:dependency) do
       Dependabot::Dependency.new(

diff --git a/nuget/spec/dependabot/nuget/update_checker/compatibility_checker_spec.rb b/nuget/spec/dependabot/nuget/update_checker/compatibility_checker_spec.rb
@@ -74,7 +74,7 @@
     XML
   end
 
-  context "#compatible?" do
+  describe "#compatible?" do
     subject(:compatible) { checker.compatible?(version) }
 
     before do

diff --git a/python/spec/dependabot/python/update_checker_spec.rb b/python/spec/dependabot/python/update_checker_spec.rb
@@ -773,7 +773,7 @@
     end
   end
 
-  context "#requirements_unlocked_or_can_be?" do
+  describe "#requirements_unlocked_or_can_be?" do
     subject { checker.requirements_unlocked_or_can_be? }
 
     it { is_expected.to eq(true) }