-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests(cli): add test for improper unicode encoding #8162
Conversation
54d47ca
to
98540e3
Compare
@bartlomieju @kdy1 the test case is still failing because the output is not as expected/valid. swc is still modifying the input string. |
@kitsonk I'm considering an option in |
For us, we would always choose to preserve input, so yes. I am not sure what the advantages of re-encoding the input would be. |
98540e3
to
44c3726
Compare
This will be fixed by swc-project/swc#1221 |
Can you try this again with the new version? |
44c3726
to
2e99b35
Compare
@kdy1 it still "modifies" the strings, but the way it re-encodes them exhibits the same behaviour, so I have updated the expected output to match the behaviour of swc. |
2e99b35
to
504148a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
and updates swc_ecma_codegen Closes denoland#8161
Fixes #8161
(Or actually will fix when swc-project/swc#1188 is fixed, this is a test case to help ensure it is fixed at the moment)