Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deno 1.5.0 bundle regression: bad Unicode character encoding #8161

Closed
nktpro opened this issue Oct 28, 2020 · 2 comments · Fixed by #8162
Closed

Deno 1.5.0 bundle regression: bad Unicode character encoding #8161

nktpro opened this issue Oct 28, 2020 · 2 comments · Fixed by #8162
Assignees
Labels
bug Something isn't working correctly cli related to cli/ dir swc related to swc (bundling/transpiling)

Comments

@nktpro
Copy link

nktpro commented Oct 28, 2020

Bundling in deno 1.5.0 would produce invalid code, due to what appears to be bad Unicode encoding in the output.

Here's a quick reproducer:

import { stringify } from "https://deno.land/std@0.75.0/encoding/yaml.ts";

console.log(stringify({
  foo: "bar",
}));

1.5.0 bundle will contain:

image

as opposed to the same snippet in 1.4.6

image

@kitsonk kitsonk added bug Something isn't working correctly cli related to cli/ dir upstream Changes in upstream are required to solve these issues labels Oct 28, 2020
@kitsonk
Copy link
Contributor

kitsonk commented Oct 28, 2020

I will isolate it a bit more, but it looks like an upstream issue with swc.

@kitsonk
Copy link
Contributor

kitsonk commented Oct 28, 2020

I think this would impact bundling as well as --no-check. It is a defect with swc, which hopefully will be fixed quickly.

@kitsonk kitsonk added swc related to swc (bundling/transpiling) and removed upstream Changes in upstream are required to solve these issues labels Nov 17, 2020
kitsonk added a commit that referenced this issue Nov 22, 2020
jannes pushed a commit to jannes/deno that referenced this issue Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly cli related to cli/ dir swc related to swc (bundling/transpiling)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants