Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(std/wasi): return flags from fd_fdstat_get #7112

Merged
merged 5 commits into from
Aug 25, 2020

Conversation

caspervonb
Copy link
Contributor

@caspervonb caspervonb commented Aug 19, 2020

This tracks fdflags from opened file descriptors and returns the tracked value in fd_stat_get.

@bartlomieju
Copy link
Member

@caspervonb can we get a test exercising this change?

@caspervonb
Copy link
Contributor Author

@caspervonb can we get a test exercising this change?

Blocking-on #7042

@caspervonb caspervonb changed the title fix(std/wasi): track fdflags in the file-descriptor table fix(std/wasi): fix offset and return flags from fd_fdstat_get Aug 25, 2020
@caspervonb caspervonb changed the title fix(std/wasi): fix offset and return flags from fd_fdstat_get fix(std/wasi): return flags from fd_fdstat_get Aug 25, 2020
@caspervonb
Copy link
Contributor Author

Turns out there was a off by one error here too 😉

@caspervonb
Copy link
Contributor Author

This should be good to merge @bartlomieju

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit d0ccab7 into denoland:master Aug 25, 2020
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
@caspervonb caspervonb deleted the fix-std-wasi-track-fdflags branch May 24, 2021 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants