-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(std/wasi): add wasi-testsuite as a submodule #7042
Merged
ry
merged 7 commits into
denoland:master
from
caspervonb:test-std-wasi-use-upstream-test-suite
Aug 25, 2020
Merged
test(std/wasi): add wasi-testsuite as a submodule #7042
ry
merged 7 commits into
denoland:master
from
caspervonb:test-std-wasi-use-upstream-test-suite
Aug 25, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces our test suite with prebuilt test artifacts from the upstream wasi test suite.
WDYT @ry? |
Added this as a submodule in web-wasi (rewrite, lessons learned, et cetera) over at khronosproject/web-wasi#3. Preferably we can bring it in as a submodule here too so it's a simple tag bump to bring in new versions. |
Not green |
ry
approved these changes
Aug 25, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks Casper
caspervonb
added a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 21, 2021
caspervonb
added a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 24, 2021
caspervonb
added a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 24, 2021
caspervonb
added a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 24, 2021
caspervonb
added a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
caspervonb
added a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
caspervonb
added a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
caspervonb
added a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
caspervonb
added a commit
to caspervonb/deno_std
that referenced
this pull request
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces our current test suite with prebuilt test artifacts from the upstream test suite.
The test suite is a crate (quite possibly being split into per domain crates soon) of bins as a side effect of witx tooling and such being written in Rust but I'm bringing them in as prebuilt artifacts because I believe they should be considered to be immutable resources that exist outside of our required toolchain and dependency graph.
There's a little more context in WebAssembly/WASI#9. We've touched on moving it to github.com/WebAssembly eventually but for now "upstream" is me.